Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Create a verify_decoded_mpt_node for a circuit #284

Open
wants to merge 47 commits into
base: main
Choose a base branch
from

Conversation

hidenori-shinohara
Copy link
Contributor

@hidenori-shinohara hidenori-shinohara commented Nov 9, 2023

My last PR #276 cleaned up and added some minor features to the verification code in vanilla Rust. This PR re-implements the same logic in the circuit language.

image

TODO: It probably makes sense to consolidate MPTNodeFixedSize and MPTValueType but that can be in a separate PR. This PR is already really big and I don't want to keep adding stuff.

len_nodes[i],
finished,
);
let mpt_node = self.decode_mpt_node::<ENCODING_LEN, ELEMENT_LEN>(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is cleaner lol

… circuit verificaiton logic/tests for readability & better debugging experience
…cates a problem with the power function. But good progress!
…sts are still incomprehensive, so there's more to do, but the logic seems more or less accurate.
@hidenori-shinohara hidenori-shinohara force-pushed the hide/decode-verification-circuit-succinct branch from a0ab8f1 to fdec6dd Compare November 11, 2023 01:39
@hidenori-shinohara hidenori-shinohara marked this pull request as ready for review November 11, 2023 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants